Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/pull request template #16

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Conversation

LaraKraemer
Copy link
Contributor

Describe your changes

I have added a PR template in a designated .github folder. I also moved the code of conduct file into a .github folder. These two steps follow GitHub open-source best practices.

Issue ticket number and link

fixes #14

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I have followed the guidelines in the Contributing document.
  • I have added / updated documents (for bug fixes / features).

Copy link
Contributor

@A91y A91y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the location of CODE_OF_CONDUCT.md. It can be in root folder.

@LaraKraemer
Copy link
Contributor Author

Done @A91y

@LaraKraemer LaraKraemer requested a review from A91y October 16, 2024 11:07
.github/pull_request_template.md Outdated Show resolved Hide resolved
@LaraKraemer LaraKraemer requested a review from A91y October 17, 2024 13:07
@LaraKraemer
Copy link
Contributor Author

Added the reference link

Copy link
Contributor

@A91y A91y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@A91y
Copy link
Contributor

A91y commented Oct 18, 2024

Thanks @LaraKraemer

@A91y A91y merged commit 5c9e9e3 into Octasol:main Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Add PR Template
2 participants