Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Comments an unused imports #15

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Removed Comments an unused imports #15

merged 3 commits into from
Oct 22, 2024

Conversation

Zaid-B24
Copy link
Contributor

Made the necessary changes by removing unused code, also removed commented codes and unused imports

@Zaid-B24
Copy link
Contributor Author

@A91y issue no 2, about removing unused code.
I have made the necessary changes and created a new pull request

Copy link
Contributor

@A91y A91y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not update sitemap file and don't upload sitemap-0.xml

@Zaid-B24
Copy link
Contributor Author

@A91y I made the necessary changes, can u merge the PR.

@A91y
Copy link
Contributor

A91y commented Oct 16, 2024

@Zaid-B24 don't modify .gitignore and sitemap.xml

Made sitemap to original file, also changed gitignore to original file
@Zaid-B24
Copy link
Contributor Author

@A91y made the changes.

@A91y
Copy link
Contributor

A91y commented Oct 18, 2024

@Zaid-B24 use of such non-descriptive commit message is not allowed. And when you make a PR that fixes some issue, you need to link the issue to the PR.

@Zaid-B24
Copy link
Contributor Author

@A91y My bad, I restored .gitignore file to original state, also removed sitemap-0.xml from being upload. I removed the unused code and imports and commented code, this PR is in reference to issue no. #2

Copy link
Contributor

@A91y A91y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@A91y A91y merged commit 79e120b into Octasol:main Oct 22, 2024
@A91y
Copy link
Contributor

A91y commented Oct 22, 2024

Thanks @Zaid-B24

@Zaid-B24
Copy link
Contributor Author

thank you @A91y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants