Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Dropdown Menu in Mobile View After Navigation #13

Merged

Conversation

PrayanshParmar
Copy link
Contributor

Fixes:
Issue (#12)

Tasks Completed

  • Implement functionality to close the dropdown menu after a navigation option is clicked:
  • Add an event listener to the dropdown options to detect clicks. (No need to write custome listener, shadcnUI take care of event handling)
  • Ensure that the dropdown menu closes after the page navigation is initiated.
  • Test the implementation:
  • Verify that the dropdown closes on all mobile devices and orientations.
  • Check that the navigation works correctly after closing the dropdown.

Sample Video

octasoal.mp4

@A91y
Copy link
Contributor

A91y commented Oct 15, 2024

@mayank-dev07 the hover effect seems to be white bg. Please check it out.

@PrayanshParmar
Copy link
Contributor Author

I have not changed hover colour it is same as it was before.

@PrayanshParmar
Copy link
Contributor Author

Below is the previous dropdown which is not responsive, neither any howering effect nore in proper alignment, I have fixed it and given it a proper howering and alignment.

octasoal1.mp4

@A91y
Copy link
Contributor

A91y commented Oct 16, 2024

@mayank-dev07 please review this

@mayank-dev07 mayank-dev07 merged commit 2da3ced into Octasol:main Oct 17, 2024
Copy link
Contributor

@mayank-dev07 mayank-dev07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A91y this looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants