Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replacement method to get rid of the PackageVersions\Versions::ROOT_PACKAGE_NAME constant #153

Closed
Ocramius opened this issue Aug 21, 2020 · 0 comments · Fixed by #154
Closed

Add replacement method to get rid of the PackageVersions\Versions::ROOT_PACKAGE_NAME constant #153

Ocramius opened this issue Aug 21, 2020 · 0 comments · Fixed by #154
Assignees
@Ocramius
Labels
enhancement
Milestone
1.11.0

Comments

@Ocramius
Copy link
Owner

Ocramius commented Aug 21, 2020 •
edited
Loading

Addresses #139 (comment)

By having a smooth migration from PackageVersions\Versions::ROOT_PACKAGE_NAME to, for example, PackageVersions\Versions::rootPackageName(), we can get rid of the last bit of generated code in this library once moving to 2.0.0, by just dropping the PackageVersions\Versions::ROOT_PACKAGE_NAME constant.
@Ocramius Ocramius added this to the 1.11.0 milestone Aug 21, 2020
@Ocramius Ocramius self-assigned this Aug 21, 2020
Ocramius added a commit that referenced this issue Aug 21, 2020
@Ocramius
Implement #153 - added PackageVersions\Versions::rootPackageName() …
d043c87 
…as replacement for `PackageVersions\Versions::ROOT_PACKAGE_NAME`

Please use `PackageVersions\Versions::rootPackageName()` instead of `PackageVersions\Versions::ROOT_PACKAGE_NAME`,
which is deprecated, and will be removed in version `2.0.0`
@Ocramius Ocramius mentioned this issue Aug 21, 2020
Merged
Ocramius added a commit that referenced this issue Aug 21, 2020
@Ocramius
Merge pull request #154 from Ocramius/feature/#153-add-alternative-to…
f51ff2b 
…-root-package-name-constant

Implement #153 - added `PackageVersions\Versions::rootPackageName()` as replacement for `PackageVersions\Versions::ROOT_PACKAGE_NAME`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
1.11.0
1 participant
@Ocramius