Removing inbuilt plotting methods #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing code for plotting particles and fields, as this is too much maintenance and there are dedicated packages (trajan) to do this
The .env file is used to set Jupyter environment on Virtual Studio Code; so needs to be in project home, but is user-specific
for more information, see https://pre-commit.ci
… built-in plotting
…m/OceanParcels/parcels into removing_inbuilt_plotting_methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion on #1319, this PR removes the built-in functionality for
plotTrajectoriesfiles,ParticleSet.show()andFieldSet.show. These functions are not core to parcels (i.e. not needed to execute particle simulations), and plotting of trajectories can better be felt with by the newtrajanpackage.This also significantly reduces the number of lines in
parcels/, and probably increases the code coverage in codecov