Merge pull request #1279 from OceanParcels/fix_vonmises_scipy_impleme…

…ntation Fixing the vonmises distribution tests in test_diffusion
OceanParcels · Jan 11, 2023 · b7530fc · b7530fc
2 parents 56e988a + 36cdbd3
commit b7530fc
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/.github/workflows/ci-workflow-integrationtests.yml b/.github/workflows/ci-workflow-integrationtests.yml
@@ -39,6 +39,10 @@ jobs:
     runs-on: windows-latest
     steps:
       - uses: actions/checkout@master
+      - name: Configure pagefile
+        uses: al-cheb/configure-pagefile-action@v1.2
+        with:
+          minimum-size: 8GB
       - name: Test Windows
         env:
           OS_NAME: win

diff --git a/.github/workflows/ci-workflow-unittests.yml b/.github/workflows/ci-workflow-unittests.yml
@@ -48,6 +48,10 @@ jobs:
     runs-on: windows-latest
     steps:
       - uses: actions/checkout@master
+      - name: Configure pagefile
+        uses: al-cheb/configure-pagefile-action@v1.2
+        with:
+          minimum-size: 8GB
       - name: Test Windows
         env:
           OS_NAME: win

diff --git a/tests/test_diffusion.py b/tests/test_diffusion.py
@@ -143,6 +143,7 @@ def vonmises(particle, fieldset, time):
     angles = np.array([p.angle for p in pset])
 
     assert np.allclose(np.mean(angles), mu, atol=.1)
-    scipy_mises = stats.vonmises.rvs(kappa, loc=mu, size=10000)
-    assert np.allclose(np.mean(angles), np.mean(scipy_mises), atol=.1)
-    assert np.allclose(np.std(angles), np.std(scipy_mises), atol=.1)
+    vonmises_mean = stats.vonmises.mean(kappa=kappa, loc=mu)
+    assert np.allclose(np.mean(angles), vonmises_mean, atol=.1)
+    vonmises_var = stats.vonmises.var(kappa=kappa, loc=mu)
+    assert np.allclose(np.var(angles), vonmises_var, atol=.1)