Update platform_model with seexplorers detailed list #277
Conversation
add a more detailed list of seaexplorer
vturpin
requested review from
glidermann,
castelao,
justinbuck,
kerfoot,
tcarval,
emmerbodc,
jenseva and
callumrollo
as code owners
|
Hi Victor, where are you getting the SeaExplorer models from? Particularly the Shallow X2 and Shallow X3? To my knowledge, Alseamar have not completed manufacture of a market ready shallow glider yet. It seems odd to already list two seperate models of it... On a seperate note, is there a reason to maintain our own vocabulary of gliders rather than use e.g. the NVSB76 sensor models vocab? https://vocab.nerc.ac.uk/collection/B76/current/ |
|
Alseamar ask us to add those models. So I reported it here. Not to forget. No there is no need for our own vocab I think NVSB76 is fine. in this list I think we are storing our need, we need to make sure this is available in the B76. |
|
Thanks for the explanation! It would be good if alseamar could provide some more information on the models on their website that we can link to. At the moment all of the SeaExplorer models point to the same web page. Perhaps something to pass onto your contact? For now I'm happy to list these as requested by alseamar until we can add them to B76 |
|
Hello @vturpin, can you or someone in Alseamar create a ticket here to request those models adding to the B76 vocab please There is a template to follow here if you click on new issue - new term |
|
@fmargirier Could you request the following terms to the control vocabulary B76 that OG1.0 is using as a reference. This is:
As you are the most expert here, feel free to remove, add or rename model as you wish. The description is also important and I am sure you have the proper descritpion internally Here is the link where you can request new terms. I think you need to create an issue for any new terms. https://github.com/nvs-vocabs/B76/issues Let me know if you face any difficulty. I am happy to help and do it if needed. |
|
Great, @vturpin can you update those URLs to this file changed and then i think this can be closed. |
Update the seaexplorer uri recently edited in NVS Remove SeaExplorer X2 shallow that does not exist
change url to uri for seaexplorer
|
Done |
|
What about specifying that the model is unknown with (undefined) or (model unknown) for these cases ? |
|
Well I haven't seen any operator not knowing about the generic model of the glider they operates. I would suggest to avoid 'unknown" but authorize the generic names like "slocum", "seaexplorer" and "seaglider" |
|
i meant spray (unkown) but you are right it is redundant and just adding weight instead of clarifying things. |
add a more detailed list of seaexplorer
Proponents:
Moderator: @OceanGlidersCommunity/format-mantainers
Type of PR
Related Issues
Dates when it got review approvals
Release checklist
ask reviewers to update their review.
to merge.
according to the final decision.
For maintainers
best to have one single moderator to guide and help this PR to move
forward. It is OK to update the moderador pass it to another one.
Comments