Skip to content

Fix light, LOBSTER, and NPZD constructors to work with Float32 #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ali-ramadhan merged 8 commits into from
Dec 11, 2025
Merged

Fix light, LOBSTER, and NPZD constructors to work with Float32 #324

ali-ramadhan merged 8 commits into from
Dec 11, 2025

Conversation

@ali-ramadhan
Copy link
Collaborator

@ali-ramadhan ali-ramadhan commented Dec 10, 2025 •
edited
Loading

With this change, TwoBandPhotosyntheticallyActiveRadiation (and thus LOBSTER) and NutrientPhytoplanktonZooplanktonDetritus can be constructed with Float32 and other float types.

Resolves #273

@ali-ramadhan ali-ramadhan mentioned this pull request Dec 10, 2025
Closed
@ali-ramadhan ali-ramadhan requested a review from jagoosw December 10, 2025 22:52
jagoosw
jagoosw approved these changes Dec 11, 2025
View reviewed changes
Copy link
Collaborator

@jagoosw jagoosw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ali-ramadhan ali-ramadhan merged commit 6eef68d into main Dec 11, 2025
14 checks passed
@ali-ramadhan ali-ramadhan deleted the ali/fix-constructors-float32 branch December 11, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jagoosw jagoosw jagoosw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MethodError when attempting to construct a Float32 LOBSTER

3 participants

@ali-ramadhan @jagoosw