Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Graham's scan algorithm implementation #10

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Graham's scan algorithm implementation #10

wants to merge 5 commits into from

Conversation

Vokerlee
Copy link

@Vokerlee Vokerlee commented May 7, 2023

Add:

  1. Graham's scan algorithm implementation
  2. A possibility to switch on and off Graham's scan while scene rendering

Obs01ete
Obs01ete reviewed May 11, 2023
View reviewed changes
Copy link
Owner

@Obs01ete Obs01ete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted

src/graham_hull.h
}
};

pcl::index_t findStartPoint() const
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very functional. Nice!

src/graham_hull.h

auto comparator = AngleComparator(indexes.front(), this);

std::sort(indexes.begin() + 1, indexes.end(), [&comparator, this](auto point_index_1, auto point_index_2)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of std algorithms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Obs01ete Obs01ete Obs01ete left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vokerlee @Obs01ete