accept 0 for full withdrawal

[HananINouman]

Summary by CodeRabbit

• Refactor
  • Simplified EOA withdrawal request function by removing an unused parameter.
  • Improved input validation logic for allocation checks.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Removes the provider parameter from the submitEOAWithdrawalRequest function signature in eoaHelpers.ts and its call site in eoa.ts. Updates input validation for allocation to use explicit undefined/null checks instead of falsy checks. Test cases updated accordingly.

Changes

Cohort / File(s)	Summary
Provider parameter removal src/eoa/eoaHelpers.ts, src/eoa/eoa.ts	Removed provider: ProviderType from the function signature and call site. Updated allocation validation to explicitly check for undefined/null instead of falsy checks.
Test updates test/eoa/eoa.spec.ts	Removed provider field from submitEOAWithdrawalRequest call in requestWithdrawal test.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Straightforward parameter removal applied consistently across call sites and tests
• Input validation change is explicit and localized
• Public API change should be verified for downstream impact

Possibly related PRs

• Hanan/eoa withdrawal #135: Directly conflicts—this PR removes the provider parameter that was added in the referenced PR.
• Hanan/await tx #137: Modifies the same function (submitEOAWithdrawalRequest) but alters its receipt-awaiting logic; parameter removal here may affect that PR's transaction handling approach.

Suggested reviewers

• agaskrobot

Poem

🐰 A provider removed, the signature grows lean,
No falsy checks—explicit null, precise and clean.
Simpler calls, less baggage to pass along,
The code hops forward, brisk and strong! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch Hanan/accept-zero-allocation

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89ff4ab and 1127583.

📒 Files selected for processing (3)

• src/eoa/eoa.ts (0 hunks)
• src/eoa/eoaHelpers.ts (1 hunks)
• test/eoa/eoa.spec.ts (0 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE