-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app: sign with Capella domain #65
Conversation
Following EIP-7044[1], sign exits with Capella domain for perpetual validity. [1]: https://eips.ethereum.org/EIPS/eip-7044
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting and style comments, otherwise I like it 💯
This reverts commit 3ed89dd.
Co-authored-by: Luke Hackett <luke@obol.tech>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 43.60% 36.21% -7.40%
==========================================
Files 14 14
Lines 1729 1814 +85
==========================================
- Hits 754 657 -97
- Misses 848 1037 +189
+ Partials 127 120 -7 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Following EIP-70441, sign exits with Capella domain for perpetual validity.
category: bug
ticket: none