-
Notifications
You must be signed in to change notification settings - Fork 132
core/fetcher: add core_fetcher_proposal_blinded metric #4117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new Prometheus gauge metric core_fetcher_proposal_blinded to track whether fetched beacon block proposals are blinded (built by MEV builders) or locally built by the beacon node. The metric uses a simple binary value where 1 indicates a blinded proposal and 0 indicates a local proposal.
Key Changes:
- Added new metric definition in
core/fetcher/metrics.go - Instrumented the proposal fetching logic to set the metric based on the
proposal.Blindedfield - Updated metrics documentation to reflect the new metric
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/metrics.md | Added documentation entry for the new core_fetcher_proposal_blinded gauge metric |
| core/fetcher/metrics.go | New file defining the proposalBlindedGauge metric using promauto |
| core/fetcher/fetcher.go | Added instrumentation to set the blinded metric value after fetching each proposal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Diogo Santos <59585571+DiogoSantoss@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4117 +/- ##
==========================================
- Coverage 56.39% 56.39% -0.01%
==========================================
Files 245 245
Lines 31169 31173 +4
==========================================
+ Hits 17578 17580 +2
Misses 11284 11284
- Partials 2307 2309 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add `core_fetcher_proposal_blinded` metric which tracks whether the fetched proposal data is blinded (built by MEV) or locally built. category: feature ticket: #4106
Cherry-picking #4117 for `v1.7.2` category: misc ticket: none



Add
core_fetcher_proposal_blindedmetric which tracks whether the fetched proposal data is blinded (built by MEV) or locally built.category: feature
ticket: #4106