Skip to content

Conversation

@DiogoSantoss
Copy link
Contributor

Add core_fetcher_proposal_blinded metric which tracks whether the fetched proposal data is blinded (built by MEV) or locally built.

category: feature
ticket: #4106

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Prometheus gauge metric core_fetcher_proposal_blinded to track whether fetched beacon block proposals are blinded (built by MEV builders) or locally built by the beacon node. The metric uses a simple binary value where 1 indicates a blinded proposal and 0 indicates a local proposal.

Key Changes:

  • Added new metric definition in core/fetcher/metrics.go
  • Instrumented the proposal fetching logic to set the metric based on the proposal.Blinded field
  • Updated metrics documentation to reflect the new metric

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
docs/metrics.md Added documentation entry for the new core_fetcher_proposal_blinded gauge metric
core/fetcher/metrics.go New file defining the proposalBlindedGauge metric using promauto
core/fetcher/fetcher.go Added instrumentation to set the blinded metric value after fetching each proposal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Diogo Santos <59585571+DiogoSantoss@users.noreply.github.com>
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.39%. Comparing base (1101cf1) to head (361797d).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4117      +/-   ##
==========================================
- Coverage   56.39%   56.39%   -0.01%     
==========================================
  Files         245      245              
  Lines       31169    31173       +4     
==========================================
+ Hits        17578    17580       +2     
  Misses      11284    11284              
- Partials     2307     2309       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DiogoSantoss DiogoSantoss added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 21, 2025
@obol-bulldozer obol-bulldozer bot merged commit 745225a into main Nov 21, 2025
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the diogo/add-blinded-metric branch November 21, 2025 12:34
DiogoSantoss added a commit that referenced this pull request Nov 27, 2025
Add `core_fetcher_proposal_blinded` metric which tracks whether the fetched proposal data is blinded (built by MEV) or locally built.

category: feature
ticket: #4106
obol-bulldozer bot pushed a commit that referenced this pull request Nov 27, 2025
Cherry-picking #4117 for `v1.7.2`

category: misc
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants