*: v1.7.1 #4049
Merged
*: v1.7.1 #4049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delay event values were being passed as `float64(delay)` instead of `delay.Seconds()` which causes Prometheus to store them incorrectly. category: bug ticket: none
Now it works on my machine :) category: bug ticket: none
Fix: Handle 404 errors gracefully in inclusion checker and improve error handling **Problem** The inclusion checker was treating 404 responses from the beacon node as errors, causing: - Unnecessary retries when blocks are missed, putting load on the beacon node - Spurious warnings for expected 404 responses (missed proposals are valid) **Solution** 1. Handle 404 errors gracefully Detect 404 status codes and treat them as "block not found" (expected behavior) Stop retrying and stop logging warnings for 404 responses Added comprehensive tests to verify correct behavior 2. Improve error handling approach Modified eth2wrap.wrapError() to use errors.Wrap() instead of errors.New() Preserves original eth2api.Error in the error chain Enables standard Go error checking with errors.As() instead of relying on logging fields Applied consistently across inclusion.go and synthproposer.go category: bug ticket: #4035
|
DiogoSantoss
approved these changes
Oct 23, 2025
pinebit
approved these changes
Oct 23, 2025
KaloyanTanev
added
the
merge when ready
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main-v1.7 #4049 +/- ##
=============================================
- Coverage 53.57% 53.53% -0.04%
=============================================
Files 224 224
Lines 37353 37366 +13
=============================================
- Hits 20011 20005 -6
- Misses 15221 15241 +20
+ Partials 2121 2120 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charon v1.7.1
#4024
#4029
#4041
category: feature
ticket: none