Skip to content

Conversation

@pinebit
Copy link
Collaborator

@pinebit pinebit commented Oct 21, 2025

Charon logging revamp.

category: refactor
ticket: #3882

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 17.33333% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.83%. Comparing base (14a1e4e) to head (c782edb).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
p2p/p2p.go 0.00% 10 Missing ⚠️
core/scheduler/scheduler.go 22.22% 7 Missing ⚠️
p2p/receive.go 16.66% 5 Missing ⚠️
app/eth2wrap/version.go 0.00% 4 Missing ⚠️
p2p/ping.go 0.00% 4 Missing ⚠️
app/monitoringapi.go 0.00% 3 Missing ⚠️
core/consensus/qbft/qbft.go 0.00% 3 Missing ⚠️
core/tracker/inclusion.go 0.00% 3 Missing ⚠️
p2p/bootnode.go 0.00% 3 Missing ⚠️
app/eth2wrap/synthproposer.go 0.00% 2 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4038      +/-   ##
==========================================
+ Coverage   53.55%   53.83%   +0.28%     
==========================================
  Files         224      242      +18     
  Lines       37348    39345    +1997     
==========================================
+ Hits        20000    21181    +1181     
- Misses      15226    15921     +695     
- Partials     2122     2243     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pinebit and others added 2 commits October 21, 2025 13:32
Co-authored-by: kalo <24719519+KaloyanTanev@users.noreply.github.com>
Signed-off-by: Andrei Smirnov <pinebit@gmail.com>
@sonarqubecloud
Copy link

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 21, 2025
@obol-bulldozer obol-bulldozer bot merged commit ecc2002 into main Oct 21, 2025
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/logging-revamp branch October 21, 2025 13:25
@pinebit pinebit mentioned this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants