Skip to content

Conversation

@KaloyanTanev
Copy link
Collaborator

It's safer to do the chain split check in the pre-prepare round.

WIP: still testing

category: feature
ticket: none
feature_flag: chain_split_halt

@KaloyanTanev KaloyanTanev self-assigned this Oct 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2025

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.50%. Comparing base (1cb7223) to head (df69843).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4011      +/-   ##
==========================================
+ Coverage   53.49%   53.50%   +0.01%     
==========================================
  Files         224      224              
  Lines       37353    37353              
==========================================
+ Hits        19982    19986       +4     
+ Misses      15254    15244      -10     
- Partials     2117     2123       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev KaloyanTanev requested a review from pinebit October 2, 2025 12:21
@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 6, 2025
@obol-bulldozer obol-bulldozer bot merged commit 7c4b6df into main Oct 6, 2025
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/chain-split-at-preprepare branch October 6, 2025 08:39
KaloyanTanev added a commit that referenced this pull request Oct 6, 2025
It's safer to do the chain split check in the pre-prepare round.

WIP: still testing

category: feature
ticket: none
feature_flag: chain_split_halt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants