*: allow --operator-enrs on publishing definition to API
#3993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaloyanTanev
changed the title
--operator-enrs on publishing cluster definition to API--operator-enrs on publishing definition to API
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3993 +/- ##
=======================================
Coverage 53.58% 53.59%
=======================================
Files 224 224
Lines 37329 37333 +4
=======================================
+ Hits 20002 20007 +5
- Misses 15208 15210 +2
+ Partials 2119 2116 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
This was referenced Sep 26, 2025
OisinKyne
reviewed
Sep 26, 2025
OisinKyne
approved these changes
Sep 26, 2025
Contributor
OisinKyne
left a comment
OisinKyne
left a comment
There was a problem hiding this comment.
One thing to fix, doesn't have to be fixed the way of my suggestion. More may be needed to pass the api validation, but I think i'm okay with putting this in main as is and finishing it on the API side mostly, maybe also in charon if needed
Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com> Signed-off-by: kalo <24719519+KaloyanTanev@users.noreply.github.com>
KaloyanTanev
added
the
merge when ready
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow operator-enrs on publishing new DKG cluster definition to API.
Small QOL improvements.
category: feature
ticket: none