Skip to content

Conversation

@pinebit
Copy link
Collaborator

@pinebit pinebit commented Sep 24, 2025

To reduce the scope of the other (DKG) PR, this work just cleans up the cmd package:

  • removed view-cluster-manifest command that is unused,
  • removed t.Parallel() as we don't allow it anywhere else,
  • disabled one flakey test that is less important vs build stability
  • other minor improvements

category: refactor
ticket: none

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 24, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
26.7% Duplication on New Code (required ≤ 15%)

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.65%. Comparing base (41ae91c) to head (d27481c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/exit_delete.go 50.00% 1 Missing ⚠️
cmd/exit_fetch.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3990      +/-   ##
==========================================
- Coverage   55.07%   53.65%   -1.43%     
==========================================
  Files         225      224       -1     
  Lines       37264    37172      -92     
==========================================
- Hits        20524    19943     -581     
- Misses      14565    15109     +544     
+ Partials     2175     2120      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@obol-bulldozer obol-bulldozer bot merged commit c1812e8 into main Sep 24, 2025
11 of 12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/cmd-tests-cleanup branch September 24, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants