Skip to content

Conversation

pinebit
Copy link
Collaborator

@pinebit pinebit commented Sep 15, 2025

  • Added pedersen DKG algorithm using kyber library.
  • Added alpha reshare command.
  • Added alpha add-operators command
  • Added alpha remove-operators command
  • Ongoing code refactoring.

category: feature
ticket: #3672

Copilot

This comment was marked as outdated.

@ObolNetwork ObolNetwork deleted a comment from Copilot AI Sep 15, 2025
@pinebit pinebit requested a review from aadomn September 15, 2025 09:42
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 58.40801% with 789 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.84%. Comparing base (c1812e8) to head (3414500).

Files with missing lines Patch % Lines
dkg/dkgpb/v1/pedersen.pb.go 0.00% 324 Missing ⚠️
dkg/pedersen/reshare.go 52.68% 79 Missing and 18 partials ⚠️
dkg/pedersen/board.go 65.65% 48 Missing and 20 partials ⚠️
dkg/protocol.go 57.14% 44 Missing and 22 partials ⚠️
dkg/pedersen/dkg.go 69.71% 30 Missing and 13 partials ⚠️
dkg/protocolsteps.go 65.00% 28 Missing and 14 partials ⚠️
cmd/addoperators.go 63.33% 21 Missing and 1 partial ⚠️
cmd/removeoperators.go 61.40% 21 Missing and 1 partial ⚠️
cmd/reshare.go 66.15% 21 Missing and 1 partial ⚠️
dkg/pedersen/proto.go 85.71% 12 Missing and 6 partials ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3977      +/-   ##
==========================================
+ Coverage   53.65%   53.84%   +0.18%     
==========================================
  Files         224      241      +17     
  Lines       37172    39020    +1848     
==========================================
+ Hits        19946    21010    +1064     
- Misses      15105    15773     +668     
- Partials     2121     2237     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pinebit pinebit marked this pull request as ready for review September 16, 2025 03:36
@pinebit pinebit requested a review from Copilot September 22, 2025 12:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 57 out of 58 changed files in this pull request and generated 6 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ObolNetwork ObolNetwork deleted a comment from Copilot AI Sep 22, 2025
@ObolNetwork ObolNetwork deleted a comment from Copilot AI Sep 22, 2025
@pinebit pinebit force-pushed the pinebit/pedersen-dkg branch from 272b080 to e0de187 Compare September 24, 2025 13:29
@pinebit pinebit force-pushed the pinebit/pedersen-dkg branch from e0de187 to 4497e38 Compare September 24, 2025 14:44
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant