cluster: use slices.Contains to simplify code #3970
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fengyuchuanshen <fengyuchuanshen@outlook.com>
|
KaloyanTanev
approved these changes
Sep 11, 2025
KaloyanTanev
added
the
merge when ready
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3970 +/- ##
==========================================
+ Coverage 55.05% 55.10% +0.05%
==========================================
Files 225 225
Lines 37234 37230 -4
==========================================
+ Hits 20499 20517 +18
+ Misses 14566 14546 -20
+ Partials 2169 2167 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KaloyanTanev
removed
the
merge when ready
|
Hi @fengyuchuanshen , thanks for your contribution! Would it be possible to fix the issues spotted by |
|
No activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use slices.Contains to simplify code
category: refactor
ticket: none