Skip to content

*: chain split halt #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
obol-bulldozer merged 16 commits into from
Sep 24, 2025
Merged

*: chain split halt #3946

obol-bulldozer merged 16 commits into from
Sep 24, 2025

Conversation

@KaloyanTanev
Copy link
Collaborator

@KaloyanTanev KaloyanTanev commented Sep 2, 2025 •
edited
Loading

Chain split halt feature. Details regarding the feature can be found in the ticket and the design doc.

category: feature
ticket: #3876
feature_flag: chain_split_halt

@KaloyanTanev KaloyanTanev marked this pull request as draft September 2, 2025 16:05
@KaloyanTanev KaloyanTanev force-pushed the kalo/chain-split-halt-solution2 branch from 7082eb9 to 72ff324 Compare September 9, 2025 16:47
@codecov
Copy link

codecov bot commented Sep 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 52.69710% with 114 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.57%. Comparing base (c1812e8) to head (45e9c33).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/consensus/qbft/qbft.go 23.33% 91 Missing and 1 partial ⚠️
core/qbft/qbft.go 86.23% 15 Missing ⚠️
core/consensus/qbft/msg.go 25.00% 6 Missing ⚠️
app/app.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3946      +/-   ##
==========================================
- Coverage   53.65%   53.57%   -0.09%     
==========================================
  Files         224      224              
  Lines       37172    37329     +157     
==========================================
+ Hits        19946    19999      +53     
- Misses      15105    15213     +108     
+ Partials     2121     2117       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev KaloyanTanev marked this pull request as ready for review September 23, 2025 12:23
pinebit
pinebit approved these changes Sep 23, 2025
View reviewed changes
Copy link
Collaborator

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KaloyanTanev KaloyanTanev self-assigned this Sep 23, 2025
@KaloyanTanev KaloyanTanev force-pushed the kalo/chain-split-halt-solution2 branch from caf9667 to 45e9c33 Compare September 24, 2025 15:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 24, 2025

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 24, 2025
@obol-bulldozer obol-bulldozer bot merged commit 18439d3 into main Sep 24, 2025
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/chain-split-halt-solution2 branch September 24, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinebit pinebit pinebit approved these changes

@DiogoSantoss DiogoSantoss Awaiting requested review from DiogoSantoss

Assignees

@KaloyanTanev KaloyanTanev

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KaloyanTanev @pinebit