cmd: add hostname verification #3901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3901 +/- ##
==========================================
- Coverage 55.12% 55.11% -0.02%
==========================================
Files 225 225
Lines 36696 36699 +3
==========================================
- Hits 20229 20226 -3
- Misses 14344 14352 +8
+ Partials 2123 2121 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KaloyanTanev
approved these changes
Aug 12, 2025
pinebit
reviewed
Aug 12, 2025
pinebit
approved these changes
Aug 12, 2025
|
DiogoSantoss
added
the
merge when ready
DiogoSantoss
added a commit
that referenced
this pull request
Aug 13, 2025
Add external hostname verification to prevent users from passing `--p2p-external-hostname` with empty value followed by another flag. category: feature ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add external hostname verification to prevent users from passing
--p2p-external-hostnamewith empty value followed by another flag.category: feature
ticket: none