testutil/integration: fix nightly test behavior #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing errors around with channels, which in this specific test might alter timings, just panic when error is not of "context canceled" kind, during the induced restart phase. Not ideal, but simple and effective.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3343 +/- ##
=======================================
Coverage 58.68% 58.69%
=======================================
Files 210 210
Lines 30290 30290
=======================================
+ Hits 17777 17779 +2
+ Misses 10621 10617 -4
- Partials 1892 1894 +2 ☔ View full report in Codecov by Sentry. |
KaloyanTanev
approved these changes
Oct 16, 2024
pinebit
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing errors around with channels, which in this specific test might alter timings, just panic when error is not of "context canceled" kind, during the induced restart phase.
Not ideal, but simple and effective.
category: bug
ticket: none