*: consensus abstraction #3327
Open
*: consensus abstraction #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3327 +/- ##
==========================================
+ Coverage 58.68% 58.82% +0.14%
==========================================
Files 210 216 +6
Lines 30290 30449 +159
==========================================
+ Hits 17777 17913 +136
- Misses 10621 10636 +15
- Partials 1892 1900 +8 ☔ View full report in Codecov by Sentry. |
pinebit
changed the title
gsora
reviewed
Oct 15, 2024
| protocolID string | ||
| } | ||
|
|
||
| func NewConsensusMetrics(protocolID string) ConsensusMetrics { |
There was a problem hiding this comment.
Weird that golangci-lint didn't complain for missing godoc?
There was a problem hiding this comment.
It does not complain indeed. I will go over every exported function and add godoc.
|
Added @OisinKyne to review at least:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
ConsensusControllerinterface.consensuspackage with increased test coverage.cluster run --consensus-protocol=xyzflag.docs/consensus.mdcategory: feature
ticket: #3304