Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: removing mutable config #3307

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Oct 1, 2024

Removing the odd mutable config and the connection with the infosync as a part of ongoing consensus logic refactoring.

category: refactor
ticket: #3305

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to fix "nested context" linter error

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.85%. Comparing base (10a465d) to head (d723fe1).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
app/app.go 0.00% 6 Missing ⚠️
core/validatorapi/validatorapi.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3307      +/-   ##
==========================================
+ Coverage   57.80%   57.85%   +0.04%     
==========================================
  Files         211      210       -1     
  Lines       30616    30588      -28     
==========================================
- Hits        17699    17697       -2     
+ Misses      11015    10992      -23     
+ Partials     1902     1899       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 1, 2024

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 3, 2024
@obol-bulldozer obol-bulldozer bot merged commit 9caf47d into main Oct 3, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/remove-mutable-conf branch October 3, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants