*: fix flaky testpeers test #3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3267 +/- ##
==========================================
+ Coverage 57.69% 57.77% +0.07%
==========================================
Files 211 211
Lines 30396 30418 +22
==========================================
+ Hits 17536 17573 +37
+ Misses 10972 10960 -12
+ Partials 1888 1885 -3 ☔ View full report in Codecov by Sentry. |
KaloyanTanev
force-pushed
the
kalo/fix-testpeers-flaky-test
branch
12 times, most recently
from
79dc8a0
to
b50ec3a
Compare
KaloyanTanev
force-pushed
the
kalo/fix-testpeers-flaky-test
branch
from
b50ec3a
to
4aff1e1
Compare
|
gsora
approved these changes
Sep 10, 2024
pinebit
approved these changes
Sep 10, 2024
KaloyanTanev
added
the
merge when ready
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Fixing flaky test in previous PR #3267 revealed another issue. Fixing that one, which is purely unit test related. category: test ticket: none
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
After #3267 was merged, on `ctx.Done()` we push the latest unfinished test. This causes out of range in the outer function in some ocassions. category: bug ticket: none
pinebit
pushed a commit
that referenced
this pull request
Sep 16, 2024
- fix test peers on timeout, sometimes it went in the case where the current context is done, but the result of the currently running test wasn't sent to the channel - fix wrongly named variables category: test ticket: none
pinebit
pushed a commit
that referenced
this pull request
Sep 16, 2024
Fixing flaky test in previous PR #3267 revealed another issue. Fixing that one, which is purely unit test related. category: test ticket: none
pinebit
pushed a commit
that referenced
this pull request
Sep 16, 2024
After #3267 was merged, on `ctx.Done()` we push the latest unfinished test. This causes out of range in the outer function in some ocassions. category: bug ticket: none
Merged
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
For release v1.1.1 cherry picked: * [core/validatorapi: workaround for Gnosis proposals](#3238) * [*: enable gnosis hotfix automatically](#3257) *: [fix flaky testpeers test #3267](#3267) * [cmd: increase testpeers tests timeouts #3268](#3268) * [cmd: fix test peers out of range #3280](#3280) * [testutil: update docker-compose command to docker compose](#3249) category: misc ticket: none
gsora
pushed a commit
that referenced
this pull request
Sep 18, 2024
- fix test peers on timeout, sometimes it went in the case where the current context is done, but the result of the currently running test wasn't sent to the channel - fix wrongly named variables category: test ticket: none
gsora
pushed a commit
that referenced
this pull request
Sep 18, 2024
Fixing flaky test in previous PR #3267 revealed another issue. Fixing that one, which is purely unit test related. category: test ticket: none
gsora
pushed a commit
that referenced
this pull request
Sep 18, 2024
After #3267 was merged, on `ctx.Done()` we push the latest unfinished test. This causes out of range in the outer function in some ocassions. category: bug ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
category: test
ticket: none