Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: flag refactors #3198

Merged
merged 6 commits into from
Jul 26, 2024
Merged

*: flag refactors #3198

merged 6 commits into from
Jul 26, 2024

Conversation

KaloyanTanev
Copy link
Contributor

@KaloyanTanev KaloyanTanev commented Jul 26, 2024

  • Change Obol's API default URL in flags to include /v1
  • validator-pubkey to validator-public-key in flag description
  • Rename test command measurement from Bad to Poor
  • Increase test peer unit tests timeout
  • bump ethdo version in compose tests to 1.35.2

category: misc
ticket: none

@github-actions github-actions bot added the branch-invalid PR raised against invalid branch. Not a main or release branch. label Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 8.57143% with 32 lines in your changes missing coverage. Please review.

Project coverage is 57.98%. Comparing base (3f3e822) to head (1ffd067).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/testperformance.go 16.66% 7 Missing and 3 partials ⚠️
cmd/testbeacon.go 0.00% 4 Missing and 2 partials ⚠️
cmd/testpeers.go 0.00% 3 Missing and 3 partials ⚠️
cmd/testvalidator.go 0.00% 2 Missing and 2 partials ⚠️
cmd/exit.go 0.00% 2 Missing ⚠️
cmd/testmev.go 0.00% 1 Missing and 1 partial ⚠️
cmd/createcluster.go 0.00% 1 Missing ⚠️
cmd/dkg.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3198      +/-   ##
==========================================
- Coverage   58.02%   57.98%   -0.04%     
==========================================
  Files         211      211              
  Lines       30253    30253              
==========================================
- Hits        17554    17542      -12     
- Misses      10803    10815      +12     
  Partials     1896     1896              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from kalo/charon-performance-test to main July 26, 2024 14:55
@KaloyanTanev KaloyanTanev removed the branch-invalid PR raised against invalid branch. Not a main or release branch. label Jul 26, 2024
@KaloyanTanev KaloyanTanev self-assigned this Jul 26, 2024
Copy link
Contributor

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion about preferring "Okay" instead of "Average" can be ignored until a future PR. Again its a nitpick, we don't really know what the average latency is to a relay, so okay is a more vague word than average. :)

cmd/exit.go Outdated Show resolved Hide resolved
cmd/test.go Show resolved Hide resolved
Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
Copy link

sonarcloud bot commented Jul 26, 2024

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 26, 2024
@obol-bulldozer obol-bulldozer bot merged commit 9755f0a into main Jul 26, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/refactor-flags branch July 26, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants