Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: beacon node API timeouts #3164

Merged
merged 4 commits into from
Jul 12, 2024
Merged

cmd: beacon node API timeouts #3164

merged 4 commits into from
Jul 12, 2024

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Jul 4, 2024

Add two CLI flags for run:

  • --beacon-node-timeout, which allows users to specify a custom HTTP timeout used for beacon node API calls
  • --beacon-node-submit-timeout, that allows users to specify a custom HTTP timeout used for submission beacon node API calls, like block and attestation submission.

Both flag default to the previous 2 seconds timeout.

category: feature
ticket: none

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 28 lines in your changes missing coverage. Please review.

Project coverage is 56.68%. Comparing base (82d6f70) to head (b15f7dd).

Files Patch % Lines
app/app.go 0.00% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
+ Coverage   56.65%   56.68%   +0.02%     
==========================================
  Files         208      208              
  Lines       29202    29216      +14     
==========================================
+ Hits        16545    16561      +16     
  Misses      10828    10828              
+ Partials     1829     1827       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add two CLI flags for `run`:
 - `--beacon-node-timeout`, which allows users to specify a custom HTTP timeout used for beacon node API calls
 - `--beacon-node-submit-timeout`, that allows users to specify a custom HTTP timeout used for submission beacon node API calls, like block and attestation submission.

Both flag default to the previous 2 seconds timeout.
@gsora gsora force-pushed the gsora/custom-bn-timeouts branch from 3e8d7e0 to b15f7dd Compare July 4, 2024 14:48
cmd/run.go Outdated Show resolved Hide resolved
Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
@gsora gsora requested a review from OisinKyne July 5, 2024 12:43
Copy link

sonarcloud bot commented Jul 5, 2024

Copy link
Contributor

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely sure of app/app.go, but LGTM at least.

@gsora
Copy link
Collaborator Author

gsora commented Jul 5, 2024

I'll wait for protocol team's review before merging.

Thanks for your help on the CLI arguments copy!

@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 12, 2024
@obol-bulldozer obol-bulldozer bot merged commit 3831793 into main Jul 12, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/custom-bn-timeouts branch July 12, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants