Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: deprecate VersionedSignedBlindedProposal #3155

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Jun 25, 2024

Convert VersionedSignedProposals to their blinded counterpart (requested by go-eth2-client & Beacon API spec) on-demand, so that the execution flow is simpler to understand and debug.

category: refactor
ticket: none

Convert VersionedSignedProposals to their blinded counterpart (requested by go-eth2-client & Beacon API spec) on-demand, so that the execution flow is simpler to understand and debug.
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 50 lines in your changes missing coverage. Please review.

Project coverage is 56.72%. Comparing base (551c898) to head (e76df29).

Files Patch % Lines
core/signeddata.go 0.00% 37 Missing ⚠️
core/bcast/bcast.go 33.33% 8 Missing ⚠️
core/tracker/inclusion.go 54.54% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3155      +/-   ##
==========================================
- Coverage   56.89%   56.72%   -0.18%     
==========================================
  Files         208      208              
  Lines       29365    29202     -163     
==========================================
- Hits        16707    16564     -143     
+ Misses      10817    10811       -6     
+ Partials     1841     1827      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/signeddata.go Outdated Show resolved Hide resolved
core/tracker/inclusion.go Outdated Show resolved Hide resolved
testutil/fuzz.go Outdated Show resolved Hide resolved
@gsora gsora requested a review from pinebit June 25, 2024 14:49
Copy link

sonarcloud bot commented Jun 25, 2024

@@ -0,0 +1,350 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add this, do we still need to keep the golden blinded equivalent? Also, probably it would be nice to include "blinded": false in the non-#01 version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm well there's no value so it'll be false by default

keep the golden blinded equivalent

you mean the golden files for VersionedSignedBlindedProposal?

@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 25, 2024
@obol-bulldozer obol-bulldozer bot merged commit c6cdc3d into main Jun 25, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/deprecate-versionedsignedblindedproposal branch June 25, 2024 15:53
gsora added a commit that referenced this pull request Jun 25, 2024
Convert `VersionedSignedProposals` to their blinded counterpart (requested by go-eth2-client & Beacon API spec) on-demand, so that the execution flow is simpler to understand and debug.

category: refactor
ticket: none
obol-bulldozer bot pushed a commit that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants