Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/tracker: track blinded proposals #3149

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Jun 22, 2024

Do the same type casting we do in core/bcast to switch on the type of block proposal.

Add a test to check for this property.

category: bug
ticket: none

Do the same type casting we do in core/bcast to switch on the type of
block proposal.

Add a test to check for this property.
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 56.80%. Comparing base (80d55bc) to head (00f6385).
Report is 1 commits behind head on main.

Files Patch % Lines
core/tracker/inclusion.go 46.42% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3149      +/-   ##
==========================================
- Coverage   56.86%   56.80%   -0.06%     
==========================================
  Files         208      208              
  Lines       29337    29356      +19     
==========================================
- Hits        16683    16677       -6     
- Misses      10815    10836      +21     
- Partials     1839     1843       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@KaloyanTanev KaloyanTanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now, so we potentially see if this will fix block proposals for during the weekend. We will jump into more details for VersionedSignedProposal and VersionedSignedBlindedProposal on Monday.

Copy link

sonarcloud bot commented Jun 22, 2024

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 22, 2024
@obol-bulldozer obol-bulldozer bot merged commit b66e063 into main Jun 22, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/tracker-blinded-fix branch June 22, 2024 11:46
gsora added a commit that referenced this pull request Jun 25, 2024
Do the same type casting we do in core/bcast to switch on the type of block proposal.

Add a test to check for this property.

category: bug
ticket: none
obol-bulldozer bot pushed a commit that referenced this pull request Jun 25, 2024
- #3144
- #3149
- #3150

category: misc
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants