*: not https warning to show only on http #3124
Conversation
|
| @@ -1089,7 +1089,7 @@ func validateKeymanagerFlags(ctx context.Context, addr, authToken string) error | |||
| return errors.Wrap(err, "failed to parse keymanager addr", z.Str("addr", addr)) | |||
| } | |||
|
|
|||
| if keymanagerURL.Scheme != "https" { | |||
| if keymanagerURL.Scheme == "http" { | |||
There was a problem hiding this comment.
can Scheme be empty string? and what protocol will be running if it's empty?
There was a problem hiding this comment.
Yes, that is the case if you don't specify key manager.
There was a problem hiding this comment.
If it's empty it would mean there is no external key manager, so it won't use it at all.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3124 +/- ##
==========================================
- Coverage 56.77% 56.74% -0.03%
==========================================
Files 208 208
Lines 29305 29305
==========================================
- Hits 16637 16630 -7
- Misses 10831 10835 +4
- Partials 1837 1840 +3 ☔ View full report in Codecov by Sentry. |
KaloyanTanev
added
the
merge when ready
A warning log was output in the case "https" is missing as a scheme. This triggered anytime it was not https, even if the scheme was empty.
Linter complained for repeated "http", so I've moved it to const alongside "https".
category: misc
ticket: none