core/validatorapi: relax SlotFromTimestamp checks
#3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export `SlotFromTimestamp` instead of keeping two equal implementation. Relax `SlotFromTimestamp` timestamp checks: if a timestamp comes before genesis time as fetched from the beacon node, fall back to `time.Now()` as timestamp. This function is only ever used to check for validator registration validity, which has never been formalized and can be relaxed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3066 +/- ##
==========================================
+ Coverage 56.33% 56.40% +0.07%
==========================================
Files 208 208
Lines 28846 28839 -7
==========================================
+ Hits 16251 16268 +17
+ Misses 10791 10773 -18
+ Partials 1804 1798 -6 ☔ View full report in Codecov by Sentry. |
pinebit
approved these changes
May 6, 2024
|
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export
SlotFromTimestampinstead of keeping two equal implementation.Relax
SlotFromTimestamptimestamp checks: if a timestamp comes before genesis time as fetched from the beacon node, fall back totime.Now()as timestamp.This function is only ever used to check for validator registration validity, which has never been formalized and can be relaxed.
category: refactor
ticket: none