cmd: alpha test beacon #3059
Merged
cmd: alpha test beacon #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaloyanTanev
force-pushed
the
kalo/alpha-charon-test-beacon
branch
from
903f90e
to
fcb01fd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3059 +/- ##
==========================================
+ Coverage 54.63% 54.95% +0.32%
==========================================
Files 207 209 +2
Lines 29145 29786 +641
==========================================
+ Hits 15922 16370 +448
- Misses 11383 11600 +217
+ Partials 1840 1816 -24 ☔ View full report in Codecov by Sentry. |
gsora
approved these changes
Apr 30, 2024
pinebit
approved these changes
May 8, 2024
|
KaloyanTanev
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charon alpha beacon node testing. Structure is identical to what we have in peers tests, with the exception that here we do not have separation between self and external (peers). The 4 test cases can be fired against multiple beacon nodes.
To test on your own machine:
Similarly to peers tests, const values used to determine whether a measured test result is average or bad are nothing more than estimates for now on my side. I am open to suggestions on that front.
category: feature
ticket: #2998