Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: charon alpha test skeleton #3008

Merged
merged 19 commits into from
Apr 8, 2024
Merged

Conversation

KaloyanTanev
Copy link
Contributor

@KaloyanTanev KaloyanTanev commented Apr 1, 2024

Add the skeleton framework for the charon alpha test command. Prepare all the necessities required to start building different test suites. Set the first 3 envisioned categories - peers, beacon node and validator client.

To try it out:

make charon
./charon alpha test peers --enrs="test" --output-toml="peers.toml" --timeout="3s"
./charon alpha test beacon --endpoints="test" --output-toml="beacon.toml" --timeout="3s"
./charon alpha test validator --output-toml="validator.toml" --timeout="3s"

From all the flags above, only enrs and endpoints are mandatory.

N.B.: Implementation of peers, beacon node and validator client tests are out of the scope of this PR.

Edit: Unit tests are not yet of this PR, keep in mind when reviewing

category: feature
ticket: #2995

@KaloyanTanev KaloyanTanev self-assigned this Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 81.21622% with 139 lines in your changes are missing coverage. Please review.

Project coverage is 54.77%. Comparing base (b7ece61) to head (d754a7d).
Report is 2 commits behind head on main.

Files Patch % Lines
cmd/test.go 66.92% 36 Missing and 6 partials ⚠️
cmd/ascii.go 57.14% 27 Missing ⚠️
cmd/testpeers.go 88.74% 23 Missing and 3 partials ⚠️
cmd/testbeacon.go 89.11% 12 Missing and 4 partials ⚠️
cmd/testvalidator.go 87.50% 12 Missing and 4 partials ⚠️
cmd/duration.go 82.05% 6 Missing and 1 partial ⚠️
cmd/cmd.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3008      +/-   ##
==========================================
+ Coverage   54.02%   54.77%   +0.74%     
==========================================
  Files         200      206       +6     
  Lines       28097    28837     +740     
==========================================
+ Hits        15180    15796     +616     
- Misses      11114    11223     +109     
- Partials     1803     1818      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaloyanTanev KaloyanTanev force-pushed the kalo/alpha-charon-test-skeleton branch from 96007c0 to ebbdbe7 Compare April 1, 2024 11:43
Copy link
Contributor

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided my comments

cmd/test.go Outdated Show resolved Hide resolved
cmd/test.go Outdated Show resolved Hide resolved
cmd/test.go Outdated Show resolved Hide resolved
cmd/test.go Outdated Show resolved Hide resolved
cmd/test.go Outdated Show resolved Hide resolved
cmd/testbeacon.go Outdated Show resolved Hide resolved
cmd/testbeacon.go Outdated Show resolved Hide resolved
cmd/testpeers.go Outdated Show resolved Hide resolved
cmd/testpeers.go Outdated Show resolved Hide resolved
cmd/test.go Outdated Show resolved Hide resolved
@pinebit pinebit requested a review from gsora April 1, 2024 13:50
go.mod Outdated Show resolved Hide resolved
@KaloyanTanev KaloyanTanev force-pushed the kalo/alpha-charon-test-skeleton branch from e25dbb7 to 0b2ebb2 Compare April 3, 2024 13:56
@KaloyanTanev KaloyanTanev force-pushed the kalo/alpha-charon-test-skeleton branch 2 times, most recently from 41b2f06 to 7755bbf Compare April 4, 2024 08:17
.golangci.yml Show resolved Hide resolved
cmd/test.go Show resolved Hide resolved
cmd/test.go Outdated Show resolved Hide resolved
cmd/testbeacon.go Outdated Show resolved Hide resolved
cmd/testpeers.go Outdated Show resolved Hide resolved
@KaloyanTanev KaloyanTanev force-pushed the kalo/alpha-charon-test-skeleton branch from 6d36ada to 35337eb Compare April 4, 2024 16:19
@KaloyanTanev KaloyanTanev force-pushed the kalo/alpha-charon-test-skeleton branch from ed90848 to d754a7d Compare April 8, 2024 16:15
Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
11.9% Duplication on New Code

See analysis details on SonarCloud

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 8, 2024
@obol-bulldozer obol-bulldozer bot merged commit 5cf0827 into main Apr 8, 2024
11 of 12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/alpha-charon-test-skeleton branch April 8, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants