workflows: avoid unknown/unknown architecture in ghcr #2971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2971 +/- ##
==========================================
- Coverage 54.21% 54.13% -0.08%
==========================================
Files 195 195
Lines 27525 27551 +26
==========================================
- Hits 14922 14916 -6
- Misses 10842 10875 +33
+ Partials 1761 1760 -1 ☔ View full report in Codecov by Sentry. |
xenowits
approved these changes
Mar 18, 2024
dB2510
approved these changes
Mar 18, 2024
pinebit
approved these changes
Mar 18, 2024
pinebit
approved these changes
Mar 18, 2024
gsora
approved these changes
Mar 18, 2024
|
Added a "Closes" line to the original PR description, so that #2654 gets closed automagically when this PR is merged! |
|
Hey @KaloyanTanev! When you feel comfortable, add the |
KaloyanTanev
added
the
merge when ready
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
Some packages installed from the Dockerfile failed after #2971 was merged. Reason was it used default pre-installed version of qemu - the emulator used from amd64 architecture to build the arm64 images. Qemu is suggested by Dockerhub as well. [Dockerhub](https://docs.docker.com/build/ci/github-actions/multi-platform/) [Github Issue](docker/buildx#495 (comment)) category: fixbuild ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin buildkit version in all
docker/setup-buildx-action@v2steps (N.B.: at one place v1 is used, which is using buildkit version <0.10.5, so I haven't pinned it there). Other proposed solutions didn't seem to work currently (tested on private repo).Included as well .vscode in .gitignore.
category: bug
ticket: #2654
Closes #2654