cmd/combine: fix multiple runs #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking if `validator_keys` directory exists at the end of the load manifest loop, do it earlier and exclude potential non-Charon node directories. Also make so that `--force` deletes the existing keys, if any. Solves the use case in which the user called `combine` command twice with an input directory that was also used as an output directory.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2963 +/- ##
==========================================
+ Coverage 54.09% 54.11% +0.02%
==========================================
Files 194 194
Lines 27402 27417 +15
==========================================
+ Hits 14822 14837 +15
+ Misses 10826 10823 -3
- Partials 1754 1757 +3 ☔ View full report in Codecov by Sentry. |
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking if
validator_keysdirectory exists at the end of the load manifest loop, do it earlier and exclude potential non-Charon node directories.Also make so that
--forcedeletes the existing keys, if any.Solves the use case in which the user called
combinecommand twice with an input directory that was also used as an output directory.category: bug
ticket: #2538
Closes #2538