app/z: fields refactoring #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2946 +/- ##
==========================================
+ Coverage 52.16% 52.18% +0.02%
==========================================
Files 229 229
Lines 32614 32616 +2
==========================================
+ Hits 17012 17020 +8
+ Misses 13658 13651 -7
- Partials 1944 1945 +1 ☔ View full report in Codecov by Sentry. |
pinebit
commented
Mar 6, 2024
|
govulncheck failure is addressed here: #2947 |
|
dB2510
approved these changes
Mar 6, 2024
xenowits
approved these changes
Mar 6, 2024
gsora
approved these changes
Mar 6, 2024
pinebit
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactoring for z.Field(s).
Original request came from https://github.com/ObolNetwork/charon/pull/2702/files#r1389222292.
category: refactor
ticket: #2704