Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/validatormock: supporting universal proposal #2928

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Mar 1, 2024

Added UniversalProposal support to validatormock.

category: feature
ticket: #2918

Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
29.5% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 53.53%. Comparing base (9a9e065) to head (949b156).
Report is 1 commits behind head on main.

Files Patch % Lines
testutil/validatormock/propose.go 44.64% 24 Missing and 7 partials ⚠️
testutil/validatormock/component.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2928      +/-   ##
==========================================
- Coverage   53.65%   53.53%   -0.12%     
==========================================
  Files         202      202              
  Lines       28733    28729       -4     
==========================================
- Hits        15417    15381      -36     
- Misses      11382    11415      +33     
+ Partials     1934     1933       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Mar 4, 2024
@obol-bulldozer obol-bulldozer bot merged commit 53979d1 into main Mar 4, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/universal-validatormock branch March 4, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants