cmd: remove todos #2899
cmd: remove todos #2899
Conversation
| @@ -131,8 +131,6 @@ func SignK1(m *manifestpb.Mutation, secret *k1.PrivateKey) (*manifestpb.SignedMu | |||
| } | |||
|
|
|||
| // verifyK1SignedMutation verifies that the signed mutation is signed by a k1 key. | |||
| // | |||
| // TODO(corver): Figure out no-verify case. | |||
There was a problem hiding this comment.
We verify k1 signatures, so we don't need a "no-verify" case
| @@ -104,7 +104,6 @@ func TestValidateConfigAddValidators(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // TODO(xenowits): Add more extensive tests, this is just a very simple unit test. | |||
There was a problem hiding this comment.
The test is already comprehensive enough to test the "add validators" feature
In addition to that, the add validators feature is not in production, it is under the charon alpha command
| @@ -77,7 +77,6 @@ func mustMarkFlagRequired(cmd *cobra.Command, flag string) { | |||
|
|
|||
| func runCreateDKG(ctx context.Context, conf createDKGConfig) (err error) { | |||
| // Map prater to goerli to ensure backwards compatibility with older cluster definitions. | |||
| // TODO(xenowits): Remove the mapping later. | |||
There was a problem hiding this comment.
We can remove code for goerli entirely when goerli gets deprecated in a couple of weeks
https://blog.ethereum.org/2024/01/10/goerli-dencun-announcement
| @@ -41,7 +41,7 @@ type Config struct { | |||
| MaxResPerPeer int | |||
| MaxConns int | |||
| FilterPrivAddrs bool | |||
| RelayLogLevel string // TODO(corver): Rename to LibP2PLogLevel. | |||
| @@ -94,7 +94,6 @@ func bindRunFlags(cmd *cobra.Command, config *app.Config) { | |||
| }) | |||
| } | |||
|
|
|||
| // TODO(dhruv): add more test only flags to this function. | |||
There was a problem hiding this comment.
We only have one unsafe command for now. We can always add new unsafe commands, no need for a todo for that
xenowits
added
the
merge when ready
xenowits
force-pushed
the
xenowits/remove-todos
branch
from
41c7111
to
4f4237b
Compare
|
Removes TODOs in the
cmdpackage.category: misc
ticket: none