Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/peerinfo: added builder_api_enabled metric #2890

Merged
merged 9 commits into from
Feb 20, 2024

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Feb 19, 2024

Adds app_peerinfo_builder_api_enabled metric (gauge) indicating if the peer has builder API enabled.

category: feature
ticket: #2879

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need to add mev_enabled field to peerinfo protobuf message in app/peerinfo/peerinfopb/v1/peerinfo.proto to send/receive this info cluster peers

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (987bb25) 53.65% compared to head (6341429) 53.69%.
Report is 1 commits behind head on main.

Files Patch % Lines
app/peerinfo/peerinfo.go 71.73% 12 Missing and 1 partial ⚠️
app/app.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2890      +/-   ##
==========================================
+ Coverage   53.65%   53.69%   +0.03%     
==========================================
  Files         200      200              
  Lines       28191    28212      +21     
==========================================
+ Hits        15127    15149      +22     
+ Misses      11198    11196       -2     
- Partials     1866     1867       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit
Copy link
Contributor Author

pinebit commented Feb 19, 2024

you will need to add mev_enabled field to peerinfo protobuf message in app/peerinfo/peerinfopb/v1/peerinfo.proto to send/receive this info cluster peers

Thank you, done.

app/peerinfo/metrics.go Outdated Show resolved Hide resolved
@pinebit pinebit changed the title app/peerinfo: added mev_enabled metric app/peerinfo: added builder_api_enabled metric Feb 20, 2024
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pinebit
Copy link
Contributor Author

pinebit commented Feb 20, 2024

Added Builder API column as following:
image

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@gsora gsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10, one of the most useful information for debugging purposes is now easily accessible!

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Feb 20, 2024
@obol-bulldozer obol-bulldozer bot merged commit 8ac72af into main Feb 20, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/mev-enabled-gauge branch February 20, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants