Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validatorapi: fixing failing tests #2857

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Feb 5, 2024

Fixing broken tests.

category: bug
ticket: none

Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (cfe844b) 53.44% compared to head (434caef) 53.46%.
Report is 2 commits behind head on main.

Files Patch % Lines
core/validatorapi/router.go 73.91% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2857      +/-   ##
==========================================
+ Coverage   53.44%   53.46%   +0.02%     
==========================================
  Files         200      200              
  Lines       28011    28034      +23     
==========================================
+ Hits        14971    14989      +18     
- Misses      11180    11183       +3     
- Partials     1860     1862       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Feb 5, 2024
@obol-bulldozer obol-bulldozer bot merged commit c5764e7 into main Feb 5, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/fix-router-test branch February 5, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants