Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: add simnet flag #285

Merged
merged 2 commits into from
Mar 25, 2022
Merged

app: add simnet flag #285

merged 2 commits into from
Mar 25, 2022

Conversation

corverroos
Copy link
Contributor

Adds a simnet flag to enable/disable it explicitly.

category: feature
ticket: none

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #285 (45fba20) into main (20a0b61) will increase coverage by 0.08%.
The diff coverage is 60.60%.

❗ Current head 45fba20 differs from pull request most recent head 9f47cd4. Consider uploading reports for the commit 9f47cd4 to get more accurate results

@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   58.64%   58.73%   +0.08%     
==========================================
  Files          53       53              
  Lines        4055     4066      +11     
==========================================
+ Hits         2378     2388      +10     
- Misses       1351     1356       +5     
+ Partials      326      322       -4     
Impacted Files Coverage Δ
app/app.go 62.58% <59.37%> (+0.96%) ⬆️
cmd/run.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a0b61...9f47cd4. Read the comment docs.

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@corverroos corverroos merged commit 3f557ad into main Mar 25, 2022
@corverroos corverroos deleted the corver/simnetflag branch March 25, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants