-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testutil: fixed promrated.go #2815
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2815 +/- ##
==========================================
- Coverage 53.30% 53.25% -0.06%
==========================================
Files 199 199
Lines 27700 27705 +5
==========================================
- Hits 14765 14753 -12
- Misses 11103 11125 +22
+ Partials 1832 1827 -5 ☔ View full report in Codecov by Sentry. |
cmd/cmd.go
Outdated
// passwords in valid URLs provided in ".*address.*" flags and redacting auth tokens. | ||
func redact(flag, val string) string { | ||
func Redact(flag, val string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can just copy this function to testutil/promrated/promrated.go as this not a "big" function rather than importing whole cmd package to promrated. We don't use anything else from cmd package, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, copied with slight modification.
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Fixing promrated.go (resolving TODOs).
category: misc
ticket: none