Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: more warnings on HTTP URLs #2813

Merged
merged 3 commits into from
Jan 23, 2024
Merged

*: more warnings on HTTP URLs #2813

merged 3 commits into from
Jan 23, 2024

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Jan 23, 2024

Warn if relay or definition file URLs are HTTP.

category: refactor
ticket: none

@gsora
*: more warnings on HTTP URLs
597b8e6 
Warn if relay or definition file URLs are HTTP.
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (254a0a3) 53.28% compared to head (01e83da) 53.21%.

❗ Current head 01e83da differs from pull request most recent head ec8d910. Consider uploading reports for the commit ec8d910 to get more accurate results

Files Patch % Lines
dkg/disk.go 33.33% 3 Missing and 1 partial ⚠️
p2p/bootnode.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2813      +/-   ##
==========================================
- Coverage   53.28%   53.21%   -0.08%     
==========================================
  Files         199      199              
  Lines       27696    27700       +4     
==========================================
- Hits        14759    14740      -19     
- Misses      11108    11130      +22     
- Partials     1829     1830       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pinebit
pinebit requested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong condition

dkg/disk.go Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 23, 2024
@obol-bulldozer obol-bulldozer bot merged commit f40ea19 into main Jan 23, 2024
11 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/warn-http-relay-def-url branch January 23, 2024 11:19
gsora added a commit that referenced this pull request Jan 24, 2024
@gsora
*: more warnings on HTTP URLs (#2813)
527d582 
Warn if relay or definition file URLs are HTTP.

category: refactor
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinebit pinebit pinebit approved these changes

@dB2510 dB2510 Awaiting requested review from dB2510

@xenowits xenowits Awaiting requested review from xenowits

Assignees
No one assigned
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass qs-audit v0.19.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsora @pinebit @xenowits