core: addressed some panic instances #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pinebit
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
==========================================
- Coverage 53.29% 53.26% -0.03%
==========================================
Files 199 199
Lines 27604 27602 -2
==========================================
- Hits 14711 14703 -8
- Misses 11073 11078 +5
- Partials 1820 1821 +1 ☔ View full report in Codecov by Sentry. |
xenowits
reviewed
Jan 12, 2024
| // TODO(corver): This can panic due to json unmarshalling unexpected data. | ||
| // For now, it is a good way to catch compatibility issues. But we should | ||
| // recover panics and return an error before launching mainnet. | ||
| func ParSignedDataFromProto(typ DutyType, data *pbv1.ParSignedData) (odata ParSignedData, oerr error) { |
There was a problem hiding this comment.
nowhere, but I think I cannot omit one while having names on the others..
or maybe I could just use _
gsora
approved these changes
Jan 12, 2024
| @@ -30,7 +30,8 @@ func StartDutyTrace(ctx context.Context, duty Duty, spanName string, opts ...tra | |||
| ctx, outerSpan = tracer.Start(tracer.RootedCtx(ctx, traceID), fmt.Sprintf("core/duty.%s", strings.Title(duty.Type.String()))) | |||
| ctx, innerSpan = tracer.Start(ctx, spanName, opts...) | |||
|
|
|||
| outerSpan.SetAttributes(attribute.Int64("slot", safeInt64(duty.Slot))) | |||
| slotStr := strconv.FormatUint(duty.Slot, 10) | |||
| outerSpan.SetAttributes(attribute.String("slot", slotStr)) | |||
There was a problem hiding this comment.
I don't think it should cause any ripple behaviors
pinebit
added
the
merge when ready
gsora
pushed a commit
that referenced
this pull request
Jan 24, 2024
Removed some unnecessary panic() calls and added recover() where appropriate. category: refactor ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some unnecessary panic() calls and added recover() where appropriate.
category: refactor
ticket: none