Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: fix tracker delay to capture inclusion #2424

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Jul 12, 2023

Adds inclusion checker delay to tracker analyser to capture inclusion errors. Also decreases inclusion checker delay to 4 slots from 16 slots.

category: bug
ticket: #2415

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (ae6c7fb) 53.73% compared to head (ffb0c81) 53.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2424      +/-   ##
==========================================
- Coverage   53.73%   53.71%   -0.02%     
==========================================
  Files         199      199              
  Lines       26491    26493       +2     
==========================================
- Hits        14235    14231       -4     
- Misses      10483    10491       +8     
+ Partials     1773     1771       -2     
Impacted Files Coverage Δ
app/app.go 6.78% <0.00%> (-0.02%) ⬇️
core/tracker/inclusion.go 41.86% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dB2510 dB2510 self-assigned this Jul 12, 2023
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 12, 2023
@obol-bulldozer obol-bulldozer bot merged commit f6e7c24 into main Jul 12, 2023
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the dhruv/incltracker branch July 12, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants