core/validatorapi: add response headers #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
approved these changes
Jul 11, 2023
Comment on lines
+607
to
+609
| resHeaders := make(http.Header) | ||
| resHeaders.Add("Eth-Consensus-Version", block.Version.String()) | ||
|
|
There was a problem hiding this comment.
please add a test for this 🙏
xenowits
approved these changes
Jul 12, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2419 +/- ##
==========================================
+ Coverage 53.74% 53.79% +0.04%
==========================================
Files 198 199 +1
Lines 26418 26465 +47
==========================================
+ Hits 14198 14236 +38
- Misses 10460 10462 +2
- Partials 1760 1767 +7
☔ View full report in Codecov by Sentry. |
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to write response headers for API endpoints. This is added in order to support latest beacon APIs spec change to return response headers in some endpoints. Refer:
category: feature
ticket: none