Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster/manifest: use hardcoded legacy lock hash #2416

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

corverroos
Copy link
Contributor

Cluster hashes should remain constant. This fixes the case where legacy lock files were modified and have "incorrect" hardcoded lock hashes. Use that lock hash directly instead of recalculating the correct hash.This ensure cluster hashes remain constant even for cluster running with --no-verify.

category: bug
ticket: none

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.03 ⚠️

Comparison is base (4e903ca) 53.74% compared to head (05fb334) 53.71%.

❗ Current head 05fb334 differs from pull request most recent head eced4dd. Consider uploading reports for the commit eced4dd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2416      +/-   ##
==========================================
- Coverage   53.74%   53.71%   -0.03%     
==========================================
  Files         198      196       -2     
  Lines       26418    26341      -77     
==========================================
- Hits        14198    14150      -48     
+ Misses      10460    10433      -27     
+ Partials     1760     1758       -2     
Impacted Files Coverage Δ
app/disk.go 0.00% <0.00%> (ø)
cluster/manifest/mutationlegacylock.go 53.21% <47.82%> (-2.11%) ⬇️
cluster/manifest/load.go 50.00% <100.00%> (ø)
cmd/addvalidators.go 52.44% <100.00%> (-0.58%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@obol-bulldozer obol-bulldozer bot merged commit eceed17 into main Jul 11, 2023
10 checks passed
@obol-bulldozer obol-bulldozer bot deleted the corver/legacyhash branch July 11, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants