Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/health: fix peer and error checks #2411

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

corverroos
Copy link
Contributor

Fixes the following checks:

  • high_error_log_rate align with warning check since we not only log errors when user intervention is required.
  • insufficient_connected_peers fix metric name

category: bug
ticket: none

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.22 ⚠️

Comparison is base (db4822a) 53.85% compared to head (1832892) 53.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2411      +/-   ##
==========================================
- Coverage   53.85%   53.64%   -0.22%     
==========================================
  Files         196      196              
  Lines       26271    26273       +2     
==========================================
- Hits        14149    14093      -56     
- Misses      10377    10434      +57     
- Partials     1745     1746       +1     
Impacted Files Coverage Δ
app/health/checks.go 60.86% <100.00%> (+1.77%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 7, 2023
@obol-bulldozer obol-bulldozer bot merged commit ffe4966 into main Jul 7, 2023
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the corver/fixchecks branch July 7, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants