Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: remove deprecated return value #2407

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Jul 6, 2023

Remove isLegacyLock bool return value when loading cluster from either manifest or lock file.

category: refactor
ticket: none

@xenowits xenowits self-assigned this Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.04 ⚠️

Comparison is base (faf48c8) 53.43% compared to head (ddf26eb) 53.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
- Coverage   53.43%   53.39%   -0.04%     
==========================================
  Files         196      196              
  Lines       26282    26281       -1     
==========================================
- Hits        14044    14034      -10     
- Misses      10497    10506       +9     
  Partials     1741     1741              
Impacted Files Coverage Δ
app/disk.go 0.00% <0.00%> (ø)
cmd/addvalidators.go 51.94% <57.14%> (-0.15%) ⬇️
cluster/manifest/load.go 50.00% <66.66%> (ø)
cmd/combine/combine.go 67.24% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 7, 2023
@obol-bulldozer obol-bulldozer bot merged commit 48b9cdc into main Jul 7, 2023
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the xenowits/refactor-load-manifest branch July 7, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants