Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle gracefully DKG requests from banned IP ranges #2897

Closed
2 tasks
boulder225 opened this issue Feb 22, 2024 · 1 comment · Fixed by #2898
Closed
2 tasks

Handle gracefully DKG requests from banned IP ranges #2897

boulder225 opened this issue Feb 22, 2024 · 1 comment · Fixed by #2898
Labels
protocol Protocol Team tickets V1

Comments

@boulder225
Copy link
Collaborator

🎯 Problem to be solved

  • There are issues with users trying to use the API and DKG from banned IP ranges, which leads to errors when HTML is fed into the JSON decoder due to Cloudfare blocking the requests. This issue occurred when creating a DKG for a launchpad, where the error indicated an attempt to parse HTML as JSON, suggesting Cloudfare had blocked access.

🛠️ Proposed solution

  • Investigate the handling of HTTP status codes related to redirection or blocking by Cloudfare, specifically looking into managing 300-range codes.
  • Implement more graceful error handling for non-200 HTTP responses to ensure that the system does not attempt to parse HTML as JSON.
@boulder225 boulder225 added the V1 label Feb 22, 2024
@github-actions github-actions bot added the protocol Protocol Team tickets label Feb 22, 2024
@gsora gsora mentioned this issue Feb 22, 2024
Merged
obol-bulldozer bot pushed a commit that referenced this issue Feb 27, 2024
@gsora
cluster: handle definition download error (#2898)
639492d 
Handle non-200 HTTP status code in a graceful way, returning it instead of potentially unmarshalling-related errors.

category: bug
ticket: #2897

Closes #2897.
@gsora
Copy link
Collaborator

gsora commented Feb 27, 2024

Fixed by #2898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol Protocol Team tickets V1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cluster: handle definition download error ObolNetwork/charon
2 participants
@gsora @boulder225